Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libpfm4 to Commit 332285 #239

Merged

Conversation

Treece-Burgess
Copy link
Contributor

@Treece-Burgess Treece-Burgess commented Sep 17, 2024

Pull Request Description

Current with
commit 0118612a28d270e78d1f17c24e9db0935e332285
Author: Stephane Eranian eranian@gmail.com
Date: Tue Sep 17 16:36:24 2024 -0700

remove extraneous printf in pfmlib_init_env()

Was introduced by mistake by commit:
32b7c3d6ab6b ("add LIBPFM_PROC_CPUINFO variable for Linux")

Signed-off-by: Stephane Eranian <eranian@gmail.com>

Current with
commit 3724e7ef87e71dd1de46ef4eb4ec2b1be4ea63e5
Author: Stephane Eranian eranian@gmail.com
Date: Sun Sep 15 22:29:37 2024 -0700

add LIBPFM_PROC_CPUINFO variable for Linux

Allows overriding the filename used to parse the /proc/cpuinfo
file. This can be used to detect certain CPU models, such
as on ARM. Providing an override allows testing without the actual
hardware.

Signed-off-by: Stephane Eranian <eranian@gmail.com>

Note: Built PAPI on machines with Arm Neoverse V2 and Intel(R) Xeon(R) CPU E5-2698 v4 with both being successful. Ran papi_component_avail, papi_native_avail, and papi_command_line with all three utilities running succesfully on both of the aforementioned CPU's.

Author Checklist

  • Description
    Why this PR exists. Reference all relevant information, including background, issues, test failures, etc
  • Commits
    Commits are self contained and only do one thing
    Commits have a header of the form: module: short description
    Commits have a body (whenever relevant) containing a detailed description of the addressed problem and its solution
  • Tests
    The PR needs to pass all the tests

@Treece-Burgess Treece-Burgess changed the title Update libpfm4 to Commit ea63e5 Update libpfm4 to Commit 332285 Sep 19, 2024
Treece Burgess added 2 commits September 20, 2024 13:14
Current with
commit 3724e7ef87e71dd1de46ef4eb4ec2b1be4ea63e5
Author: Stephane Eranian <eranian@gmail.com>
Date:   Sun Sep 15 22:29:37 2024 -0700

    add LIBPFM_PROC_CPUINFO variable for Linux

    Allows overriding the filename used to parse the /proc/cpuinfo
    file. This can be used to detect certain CPU models, such
    as on ARM. Providing an override allows testing without the actual
    hardware.

    Signed-off-by: Stephane Eranian <eranian@gmail.com>

Note: Built PAPI on machines with Arm Neoverse V2 and Intel(R) Xeon(R) CPU E5-2698 v4 with both being successful.
Ran papi_component_avail, papi_native_avail, and papi_command_line with all three utilities running succesfully on both
of the aforementioned CPU's.
Current with
commit 0118612a28d270e78d1f17c24e9db0935e332285
Author: Stephane Eranian <eranian@gmail.com>
Date:   Tue Sep 17 16:36:24 2024 -0700

    remove extraneous printf in pfmlib_init_env()

    Was introduced by mistake by commit:
    32b7c3d6ab6b ("add LIBPFM_PROC_CPUINFO variable for Linux")

    Signed-off-by: Stephane Eranian <eranian@gmail.com>

Note: Built PAPI on ARM Neoverse V2 with utilities such as papi_component_avail,
papi_native_avail, and papi_command_line working as expected.
@Treece-Burgess Treece-Burgess merged commit 7c6281e into icl-utk-edu:master Sep 22, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants