ROCP_SDK: Enabling agent profiling mode. #249
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adanalis
force-pushed
the
2024.06.rocprof_sdk
branch
from
e4d57c8
to
20ebfee
Compare
adanalis
force-pushed
the
2024.06.rocprof_sdk
branch
from
20ebfee
to
78b5891
Compare
bertwesarg
reviewed
Sep 30, 2024
| @@ -973,6 +942,12 @@ int setup() { | |||
| char *error_msg = NULL; | |||
| int status = 0; | |||
|
|
|||
| rpsdk_profiling_mode = RPSDK_MODE_CALLBACK_DISPATCH; | |||
| if( NULL != getenv("RPSDK_MODE_AGENT_PROFILE") ){ | |||
There was a problem hiding this comment.
this seems to be a PAPI only env var, better to prefix it with PAPI_?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The agent profiling mode (sampling) is now fully supported by the component. To activate it the user must set the environment variable RPSDK_MODE_AGENT_PROFILE=1.
However, the counter values returned by Rocprofiler-SDK when agent profiling is activated appear to be spurious.
Author Checklist
Why this PR exists. Reference all relevant information, including background, issues, test failures, etc
Commits are self contained and only do one thing
Commits have a header of the form:
module: short descriptionCommits have a body (whenever relevant) containing a detailed description of the addressed problem and its solution
The PR needs to pass all the tests