2024.09.18 intel_gpu bug fixes #253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jagode
approved these changes
Oct 9, 2024
There were previously only 8 bits allotted to enumerate the metric groups, limited the number of groups to 256. However, there are at least 1433 groups available on the Intel Ponte Vecchio architecture. These changes have been tested on the Intel Ponte Vecchio architecture.
The metric group should not be checked when PAPI_add_event() is called. It should be checked upon PAPI_start() only. These changes have been tested on the Intel Ponte Vecchio architecture.
Reset the appropriate fields in the context struct when PAPI_cleanup() is called. This corresponds to intel_gpu_update_control_state() being called with the value 'count' equal to zero. Also reset the internal metric counts when PAPI_start() is called, so that the previous values do not persist after the next PAPI_start(). These changes have been tested on the Intel Ponte Vecchio architecture.
dbarry9
force-pushed
the
2024.09.18_intel-gpu-groups
branch
from
1942be9
to
0c0ad98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR addresses bugs that were present in the intel_gpu component, namely:
This Pull Request addresses Issue #227.
These changes have been tested using an OpenCL matrix addition kernel on the Intel Ponte Vecchio architecture.
Author Checklist
Why this PR exists. Reference all relevant information, including background, issues, test failures, etc
Commits are self contained and only do one thing
Commits have a header of the form:
module: short descriptionCommits have a body (whenever relevant) containing a detailed description of the addressed problem and its solution
The PR needs to pass all the tests