counter_analysis_toolkit: Automatically detect platform in Makefile #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this would be a good addition. Personally I think using I have tested on an x86 machine and it did work properly. @dbarry9 @adanalis You both have worked much more on this than myself, what do you two think? |
|
Thank you for the feedback! |
adanalis
approved these changes
Oct 23, 2024
|
@willowec Can you rebase before we merge into master? |
…he Makefile The CAT Makefile will now use 'uname -m' to detect if the architecture is arm or x86, and otherwise assume powerpc. If ARCH is already set, it is left alone.
willowec
force-pushed
the
cat-platform-detect
branch
from
939b0c8
to
ebb84b2
Compare
|
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
When compiling the Counter Analysis Toolkit (CAT) if the wrong architecture is selected for the ARCH variable, relatively confusing compilation errors can occur. For example, compiling on an ARM machine with the default
ARCH=X86setting produces the following GCC error:gcc: error: unrecognized command-line option ‘-mfma’.To prevent this from happening, make the CAT Makefile use 'uname -m' to detect if the architecture is arm or x86, and otherwise assume powerpc. If ARCH is already set, leave it alone. This change streamlines the workflow of using the CAT on new devices.
Author Checklist
Why this PR exists. Reference all relevant information, including background, issues, test failures, etc
Commits are self contained and only do one thing
Commits have a header of the form:
module: short descriptionCommits have a body (whenever relevant) containing a detailed description of the addressed problem and its solution
The PR needs to pass all the tests