Updating Cuda Tests Makefile with -pthread #262
Merged
+5
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Treece-Burgess
force-pushed
the
10.15.24-cuda-tests-pthread
branch
2 times, most recently
from
87e0079
to
ca1144f
Compare
|
@ametere-ssi I was able to finally recreate the |
adanalis
approved these changes
Nov 11, 2024
…ncurrent_profiling to build correctly on glibc < 2.34.
Treece-Burgess
force-pushed
the
10.15.24-cuda-tests-pthread
branch
from
ca1144f
to
7f233e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
In GLIBC version 2.34, libpthread as a separate library has been removed. Most components that used to be in a separate shared object have been placed into the main libc object,
libc.so.6. Due to this, the-lpthreadflag is not needed in GLIBC >= 2.34. See the following webpage for more discussion on this topic.Even with versions of GLIBC >= 2.34 or GLIBC < 2.34, we still should place the
-pthreadflag when needed.-pthreadencompasses-lpthread, but it also defines extra macros. From the man pages for gcc the following is stated for the-pthreadflag: You should use this option consistently for both compilation and linking.Author Checklist
Why this PR exists. Reference all relevant information, including background, issues, test failures, etc
Commits are self contained and only do one thing
Commits have a header of the form:
module: short descriptionCommits have a body (whenever relevant) containing a detailed description of the addressed problem and its solution
The PR needs to pass all the tests