Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rocm: fix instanced events #66

Merged

Conversation

gcongiu
Copy link
Contributor

@gcongiu gcongiu commented Aug 18, 2023

Pull Request Description

Some events have multiple instances. The way the component was handling those events was wrong, causing such events to not work. This patch fixes the problem.

Author Checklist

  • Description
    Why this PR exists. Reference all relevant information, including background, issues, test failures, etc
  • Commits
    Commits are self contained and only do one thing
    Commits have a header of the form: module: short description
    Commits have a body (whenever relevant) containing a detailed description of the addressed problem and its solution
  • Tests
    The PR needs to pass all the tests

Copy link
Contributor

@anustuvicl anustuvicl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Some events have multiple instances. The way the component was handling
those events was wrong, causing such events to not work. This patch
fixes the problem.
@gcongiu gcongiu force-pushed the 2023.08.18_rocm-event-instance-fix branch from 66fab4e to 330a8bd Compare August 24, 2023 16:38
@gcongiu gcongiu merged commit d3d6867 into icl-utk-edu:master Aug 24, 2023
12 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants