Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple 2D viewing mode when no headset is present #421

Merged
merged 12 commits into from
Jul 14, 2023

Conversation

andybak
Copy link
Contributor

@andybak andybak commented Mar 9, 2023

No description provided.

@andybak andybak changed the title Initial stab at allowing a simple 2D viewing mode when no headset is … Initial stab at allowing a simple 2D viewing mode when no headset is present Mar 9, 2023
@andybak andybak changed the title Initial stab at allowing a simple 2D viewing mode when no headset is present Simple 2D viewing mode when no headset is present Mar 9, 2023
@andybak
Copy link
Contributor Author

andybak commented Mar 10, 2023

Checks actually pass when I retried: https://github.com/icosa-gallery/open-brush/actions/runs/4376865218

@mikeage
Copy link
Member

mikeage commented Apr 20, 2023

Copy link
Member

@mikeskydev mikeskydev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

I think the purpose of the dropdown on the error screen could be clearer. Perhaps a text line above the dropdown?

On the navigation, I felt it was far too fast. I could see some larger sketches needing that speed, but perhaps it could be modified by the shift key?

Also , the vertical camera adjustment felt back to front to how I would expect moving a camera around.

Assets/Scripts/InitNoHeadsetMode.cs Outdated Show resolved Hide resolved
@andybak
Copy link
Contributor Author

andybak commented Apr 27, 2023

Also , the vertical camera adjustment felt back to front to how I would expect moving a camera around.

I'm one of those gamers who immediately turns on "Invert Y axis" on every game. Now I can inflict my preference on the world!

Yeah. No. I guess I'll change it. :-(

@mikeage mikeage added the enhancement Feature added label May 30, 2023
@andybak
Copy link
Contributor Author

andybak commented Jun 14, 2023

I've improved this to the point where I think it's ready for review.

@andybak
Copy link
Contributor Author

andybak commented Jun 14, 2023

@mikeskydev

On the navigation, I felt it was far too fast. I could see some larger sketches needing that speed, but perhaps it could be modified by the shift key?

Just realised - I overlooked this comment and I haven't changed it. I'll update this now.

@andybak andybak requested a review from mikeskydev June 14, 2023 10:03
@andybak andybak marked this pull request as ready for review June 14, 2023 10:03
@mikeage
Copy link
Member

mikeage commented Jun 14, 2023

What is the relationship between this and Monoscopic mode? Can this replace the monoscopic build?

@andybak
Copy link
Contributor Author

andybak commented Jun 14, 2023

What is the relationship between this and Monoscopic mode? Can this replace the monoscopic build?

This is intentionally separate from monoscopic mode. It might eventually replace it but at the moment it's very different:

a) Much easier to use. WASD+mouse navigation. Monoscopic is kinda weird.
b) No editing or UI - it simply allows you to load a sketch and fly around it.

@mikeage
Copy link
Member

mikeage commented Jun 14, 2023

Ok, so it's a potential replacement, but currently feature limited. That helps. That also explains why when I tried it, many moons ago, on Mac it looked just like Monoscopic. (do we want to try for a view-only mode on Mac, or would that require spending way too much time getting it to build a VR-capable-but-not-really-so-that-it-fails-every-time build?)

@andybak
Copy link
Contributor Author

andybak commented Jun 14, 2023

That also explains why when I tried it, many moons ago, on Mac it looked just like Monoscopic.

It shouldn't do. It should initially look like this:
image

Do we want to try for a view-only mode on Mac, or would that require spending way too much time getting it to build a VR-capable-but-not-really-so-that-it-fails-every-time build?

I'd definitely like this to run on MacOS, iOS and Android. The work @mikeskydev is doing should enable both an iOS and MacOS build without errors.

For platforms without a hardware keyboard I'll have to work on the controls a bit. (I'd also like to get a build working on Android Cardboard VR)

@mikeage
Copy link
Member

mikeage commented Jun 14, 2023

I don't think we'll get there, though, because the only Mac build we have is monoscopic. We don't have an OpenXR or SteamVR build for Mac.

@mikeskydev
Copy link
Member

A mac build could run without including any of the XR plugins, which should trigger the same conditions as not having a headset plugged in

@mikeskydev mikeskydev merged commit 0dca2e2 into main Jul 14, 2023
27 checks passed
@mikeage mikeage deleted the feature/no-headset-mode branch July 17, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature added
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants