Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix index truncation when exporting large glbs #517

Merged
merged 1 commit into from
Sep 6, 2023

Conversation

andybak
Copy link
Contributor

@andybak andybak commented Sep 3, 2023

Result has been tested in Blender. I've got a fix for SDK/Toolkit..

Result has been tested in Blender. I've got a fix for SDK/Toolkit..
Copy link
Member

@mikeage mikeage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this dependent on the SDK change, or should it be merged first?

@andybak
Copy link
Contributor Author

andybak commented Sep 6, 2023

@mikeage :

Is this dependent on the SDK change, or should it be merged first?

This is hopefully a noop unless UserConfig.Flags.LargeMeshSupport is set to true - and that's currently undocumented.

@mikeage mikeage merged commit 460ff4c into main Sep 6, 2023
27 checks passed
@mikeage mikeage deleted the fix/large-mesh-export-fixes branch September 6, 2023 11:33
@mikeage mikeage added the bugfix Something has been fixed label Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Something has been fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants