Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow profiler to use bundled sketches #769

Merged
merged 7 commits into from
Oct 7, 2024
Merged

Allow profiler to use bundled sketches #769

merged 7 commits into from
Oct 7, 2024

Conversation

andybak
Copy link
Contributor

@andybak andybak commented Sep 25, 2024

No description provided.

@andybak andybak added the enhancement Feature added label Sep 25, 2024
mikeage
mikeage approved these changes Sep 25, 2024
View reviewed changes
Copy link
Member

@mikeage mikeage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I probably would have gone for getting the branch from either an environment variable or a command line parameter or something, but I suppose locally this is easier. Also, I didn't do it, so I'm not going to second guess it.

@andybak andybak merged commit c8c3182 into main Oct 7, 2024
42 checks passed
@andybak andybak deleted the feature/profile-bundled-sketches branch October 7, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikeage mikeage mikeage approved these changes

Assignees
No one assigned
Labels
enhancement Feature added
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andybak @mikeage