Fix #3333: Clicking does not select in Assemblies pane when it doesn'…

…t have focus
icsharpcode · Nov 17, 2024 · 446ce31 · 446ce31
1 parent 09ed31d
commit 446ce31
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 5 deletions.
diff --git a/ILSpy/AssemblyTree/AssemblyListPane.xaml.cs b/ILSpy/AssemblyTree/AssemblyListPane.xaml.cs
@@ -23,6 +23,7 @@
 using ICSharpCode.ILSpy.ViewModels;
 using ICSharpCode.ILSpyX.TreeView;
 
+using TomsToolbox.Wpf;
 using TomsToolbox.Wpf.Composition.AttributedModel;
 
 namespace ICSharpCode.ILSpy.AssemblyTree
@@ -56,7 +57,7 @@ protected override void OnPropertyChanged(DependencyPropertyChangedEventArgs e)
 				var selected = model.SelectedItem;
 				if (selected != null)
 				{
-					this.Dispatcher.BeginInvoke(DispatcherPriority.Background, () => {
+					this.BeginInvoke(DispatcherPriority.Background, () => {
 						ScrollIntoView(selected);
 						this.SelectedItem = selected;
 					});
@@ -69,7 +70,8 @@ protected override void OnPropertyChanged(DependencyPropertyChangedEventArgs e)
 
 				if (SelectedItem is SharpTreeNode selectedItem)
 				{
-					FocusNode(selectedItem);
+					// defer focusing, so it does not interfere with selection via mouse click
+					this.BeginInvoke(() => FocusNode(selectedItem));
 				}
 				else
 				{

diff --git a/ILSpy/AssemblyTree/AssemblyTreeModel.cs b/ILSpy/AssemblyTree/AssemblyTreeModel.cs
@@ -640,6 +640,7 @@ public void SelectNodes(IEnumerable<SharpTreeNode> nodes)
 		private void JumpToReference(object? sender, NavigateToReferenceEventArgs e)
 		{
 			JumpToReferenceAsync(e.Reference, e.InNewTabPage).HandleExceptions();
+			IsActive = true;
 		}
 
 		/// <summary>

diff --git a/ILSpy/Controls/TreeView/SharpTreeView.cs b/ILSpy/Controls/TreeView/SharpTreeView.cs
@@ -30,6 +30,8 @@
 
 using ICSharpCode.ILSpyX.TreeView;
 
+using TomsToolbox.Wpf;
+
 namespace ICSharpCode.ILSpy.Controls.TreeView
 {
 	public class SharpTreeView : ListView
@@ -396,17 +398,18 @@ void ExpandRecursively(SharpTreeNode node)
 		/// </summary>
 		public void FocusNode(SharpTreeNode node)
 		{
-			if (node == null)
-				throw new ArgumentNullException("node");
+			ArgumentNullException.ThrowIfNull(node);
+
 			ScrollIntoView(node);
+
 			// WPF's ScrollIntoView() uses the same if/dispatcher construct, so we call OnFocusItem() after the item was brought into view.
 			if (this.ItemContainerGenerator.Status == GeneratorStatus.ContainersGenerated)
 			{
 				OnFocusItem(node);
 			}
 			else
 			{
-				this.Dispatcher.BeginInvoke(DispatcherPriority.Loaded, new DispatcherOperationCallback(this.OnFocusItem), node);
+				this.BeginInvoke(DispatcherPriority.Loaded, () => OnFocusItem(node));
 			}
 		}