Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving CI/CD for Github actions #336

Merged
merged 65 commits into from
Mar 5, 2024
Merged

Improving CI/CD for Github actions #336

merged 65 commits into from
Mar 5, 2024

Conversation

MicahGale
Copy link
Collaborator

@MicahGale MicahGale commented Jan 22, 2024

Improvements:

  • Moved completely to pyproject.toml
    • deleted pytest.ini
    • delete requirements/*
  • Added coveralls support
  • Added a test report summary
  • Went completely to git based setuptools-scm for controlling version
    • version system is robust and should never lead to an error
    • versions are determined by a git tag
    • Git tag is automatically created with an action that uses semantic versioning to decide if it's a patch, minor, or major release.
  • Added badges
  • Improved deploy process.
    • implemented actual build-deploy process
    • build will:
      1. bump to a new version, and create a git tag
      2. build
      3. sign the packages with sig store
      4. Create a draft release on GitHub
      5. Upload artifacts for later deployment to PyPi
  • Created a Pull Request Template

TODO:

resolves #326, resolves #202, resolves #329, resolves #328, resolves #338.

@MicahGale MicahGale requested a review from tjlaboss February 1, 2024 04:10
@MicahGale MicahGale marked this pull request as ready for review February 1, 2024 04:10
@MicahGale
Copy link
Collaborator Author

Could you actually get to this one first?

doc/source/api/montepy.data_inputs.rst Outdated Show resolved Hide resolved
doc/source/publications.rst Outdated Show resolved Hide resolved
montepy/__main__.py Outdated Show resolved Hide resolved
montepy/__main__.py Outdated Show resolved Hide resolved
montepy/data_inputs/fill.py Show resolved Hide resolved
.github/workflows/main.yml Outdated Show resolved Hide resolved
.github/workflows/deploy.yml Show resolved Hide resolved
@MicahGale
Copy link
Collaborator Author

MicahGale commented Feb 21, 2024

Post Merge Todo:

  • enforce passing checks for all PRs to develop and main

@MicahGale
Copy link
Collaborator Author

Going to merge this without approvals because this is CI/CD, which users won't be using, and if anything goes wrong it's going to most likely fail in a way that a deploy doesn't happen, not that bad code will go out.

@MicahGale MicahGale merged commit 0885472 into idaholab:develop Mar 5, 2024
11 of 12 checks passed
@MicahGale MicahGale mentioned this pull request Mar 9, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD documentation Improvements or additions to documentation
Projects
None yet
2 participants