-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mat redesign #507
Mat redesign #507
Conversation
5849616
to
b1c2c0e
Compare
The benchmark now takes 35 seconds: https://github.com/idaholab/MontePy/actions/runs/12126919015/job/33810033767?pr=507. It looks like the logic is just now more complicated and slower and doesn't seem like there's O(N^2) scaling. I think we should just move the goal post here and deal with optimization later as planned. |
I'm thinking:
This is all to say that I think I will YOLO merge this once I:
|
I'm going to YOLO this onto Alpha-test-dev. |
Description
Please include a summary of the change and which issue is fixed if applicable. Please also include relevant motivation and context.
Design based on #475.
Material.is_atom_fraction
settable #511Checklist
additional tasks
versionadded
andversionchanged
plib
intermixed with materialsdocument migration.Write getting started and migration guide for Materials in 1.0 #606Document all random constant dictionaries in dev stuff, and add to PR checklistDocument all the random constants and dictionaries that developers may need to work with #605mix
ing