Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mat redesign #507

Merged
merged 319 commits into from
Dec 5, 2024
Merged

Mat redesign #507

merged 319 commits into from
Dec 5, 2024

Conversation

MicahGale
Copy link
Collaborator

@MicahGale MicahGale commented Aug 25, 2024

Description

Please include a summary of the change and which issue is fixed if applicable. Please also include relevant motivation and context.

Design based on #475.

Checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation (if applicable)
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

additional tasks

@MicahGale MicahGale added alpha testing Issues that came up during alpha testing bugs A deviation from expected behavior that does not reach the level of being reportable as an "Error". code improvement A feature request that will improve the software and its maintainability, but be invisible to users. labels Aug 25, 2024
@MicahGale MicahGale self-assigned this Sep 4, 2024
@MicahGale MicahGale marked this pull request as ready for review September 11, 2024 18:11
@MicahGale MicahGale marked this pull request as draft September 11, 2024 22:29
@MicahGale
Copy link
Collaborator Author

The benchmark now takes 35 seconds: https://github.com/idaholab/MontePy/actions/runs/12126919015/job/33810033767?pr=507. It looks like the logic is just now more complicated and slower and doesn't seem like there's O(N^2) scaling. I think we should just move the goal post here and deal with optimization later as planned.

@MicahGale
Copy link
Collaborator Author

I'm thinking:

  1. This is an alpha release. Let's relax
  2. Documentation to come as a separate PR into alpha-test-dev
  3. dictionary documentation is a separate concern from this and needs to be separated out.

This is all to say that I think I will YOLO merge this once I:

  1. implement and test mix
  2. Clear out/ triage the TODO items

@MicahGale MicahGale requested a review from tjlaboss December 3, 2024 23:12
@MicahGale MicahGale marked this pull request as ready for review December 3, 2024 23:12
@MicahGale
Copy link
Collaborator Author

I'm going to YOLO this onto Alpha-test-dev.

@MicahGale MicahGale merged commit 2184765 into alpha-test-dev Dec 5, 2024
21 checks passed
@MicahGale MicahGale deleted the mat_redesign branch December 5, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alpha testing Issues that came up during alpha testing bugs A deviation from expected behavior that does not reach the level of being reportable as an "Error". code improvement A feature request that will improve the software and its maintainability, but be invisible to users. feature request An issue that improves the user interface. parsers are hard Examples of where MCNP syntax is complicated and should be simplified.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant