Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed test_version to ensure it always has _version.py #574

Merged
merged 3 commits into from
Oct 29, 2024
Merged

Fixed test_version to ensure it always has _version.py #574

merged 3 commits into from
Oct 29, 2024

Conversation

MicahGale
Copy link
Collaborator

@MicahGale MicahGale commented Oct 16, 2024 •
edited
Loading

Description

This fixes test_version to make no assumptions about the users setup. It does this by running setuptools_scm first if the _version.py file is not present.

Fixes #572

Checklist

  • I have performed a self-review of my own code
  • I have added tests that prove my fix is effective or that my feature works (if applicable)

@MicahGale MicahGale linked an issue Oct 16, 2024 that may be closed by this pull request
Unit test failure (test_version) (v0.4.1) #572
Closed
@MicahGale MicahGale added bugs A deviation from expected behavior that does not reach the level of being reportable as an "Error". CI/CD code improvement A feature request that will improve the software and its maintainability, but be invisible to users. PyOpenSci / JOSS labels Oct 16, 2024
@MicahGale MicahGale self-assigned this Oct 16, 2024
@MicahGale MicahGale requested a review from tjlaboss October 17, 2024 19:44
@MicahGale MicahGale marked this pull request as ready for review October 17, 2024 19:44
tjlaboss
tjlaboss approved these changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@tjlaboss tjlaboss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, that was minorly annoying.

@MicahGale MicahGale enabled auto-merge October 29, 2024 23:37
@MicahGale MicahGale merged commit 3e546c5 into develop Oct 29, 2024
20 checks passed
@MicahGale MicahGale deleted the 572-unit-test-failure-test_version-v041 branch October 29, 2024 23:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjlaboss tjlaboss tjlaboss approved these changes

Assignees

@MicahGale MicahGale

Labels
bugs A deviation from expected behavior that does not reach the level of being reportable as an "Error". CI/CD code improvement A feature request that will improve the software and its maintainability, but be invisible to users. PyOpenSci / JOSS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unit test failure (test_version) (v0.4.1)
2 participants
@MicahGale @tjlaboss