Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 0.5.1 #585

Merged
merged 52 commits into from
Oct 30, 2024
Merged

Release 0.5.1 #585

merged 52 commits into from
Oct 30, 2024

Conversation

MicahGale
Copy link
Collaborator

@MicahGale MicahGale commented Oct 30, 2024 •
edited
Loading

Bug Fixes

tjlaboss and others added 30 commits August 2, 2024 14:52
@tjlaboss
Add simple tallies to break the tests.
eb5467e
@MicahGale
Merge branch 'develop' into pickle_tallies
9b4d15d
@MicahGale
Merge branch 'develop' into pickle_tallies
41598be
@MicahGale
Merge branch 'develop' into pickle_tallies
a1de63d
@MicahGale
Merge branch 'develop' into pickle_tallies
dd01894
@MicahGale
Merge branch 'develop' into pickle_tallies
298a4a6
@MicahGale
Merge branch 'develop' into pickle_tallies
66ff283
@MicahGale
Merge branch 'develop' into pickle_tallies
dda72f4
@MicahGale
Moved test_version to pytest.
8d256f7
@MicahGale
Ensured _version is always available in tests.
5fee5d7
@MicahGale
Setup git archive to work well with setuptools scm.
72e4dd5
@MicahGale
Started an archive test.
524d3c4
@MicahGale
Improved archive test
dce154c
@MicahGale
Did final test of archive version.
0b89d07
@MicahGale
Update main.yml
b095356 
typos -_-
@MicahGale
Added pip install step.
ac2ac60
@MicahGale
Made deep checkout.
5b9f522
@MicahGale
Made more verbose and actually fail on error.
2e5c6bf
@MicahGale
Update main.yml
8332739 
fix typo
@MicahGale
debugging.
0fa943d
@MicahGale
debug
21675aa
@MicahGale
debug
8205595
@MicahGale
Converted to manual archive.
f4bb540
@MicahGale
Update main.yml
cccf9cc
@MicahGale
Update main.yml
ee06768
@MicahGale
Try deleting arhcive tests
ee075ec
@MicahGale
Updated test to replicate #580
da04fdc
@MicahGale
Implemented _grab_beginning_comment for all SyntaxNode.
237ba09
@MicahGale
Added #580 to changelog.
ead7f45
@MicahGale
Started documenting how Importance works.
34ea7e5
MicahGale and others added 18 commits October 24, 2024 17:39
@MicahGale
Made method to track previous object for grabbing comments. Not sure …
f73af07 
…if keeping.
@MicahGale
Made sure tokens generator don't persist.
0e988bf
@MicahGale
updated tests to handle updated model with tallies.
f77b1fa
@MicahGale
Update syntax tree to be as expected in tallies.
06137b4
@MicahGale
Just forbidding the sly Parser objects. They are just sloppy.
6163536
@MicahGale
Added #468 to changelog.
9ac5fed
@MicahGale
Merge pull request #468 from idaholab/pickle_tallies
2f9a0c1
@MicahGale
Merge branch 'develop' into 572-unit-test-failure-test_version-v041
1e615bd
@MicahGale
Merge pull request #574 from idaholab/572-unit-test-failure-test_vers…
3e546c5 
…ion-v041
@MicahGale
Merge branch 'develop' into 576-make-version-info-more-reliable-for-g…
c13b0e4 
…it-archive
@MicahGale
Merge pull request #577 from idaholab/576-make-version-info-more-reli…
2850c97 
…able-for-git-archive
@tjlaboss
The integration added a 4th line.
2ee8e33
@tjlaboss
Merge branch 'develop' into 580-syntaxnode-object-has-no-attribute-_g…
fc0fdb9 
…rab_beginning_comment
@tjlaboss
----
c87d7fe
@tjlaboss
Fix importance integration test for new comments
59ac966
@MicahGale
Gave up and just suppress ending blank lines.
92e50b3
@MicahGale
Cleaned up syntax thanks to @tjlaboss.
e0f324f
@MicahGale
Merge pull request #582 from idaholab/580-syntaxnode-object-has-no-at…
c0bbeba 
…tribute-_grab_beginning_comment

Fixed SyntaxNode AttributeError.
@MicahGale MicahGale added bugs A deviation from expected behavior that does not reach the level of being reportable as an "Error". parsers are hard Examples of where MCNP syntax is complicated and should be simplified. labels Oct 30, 2024
@MicahGale MicahGale self-assigned this Oct 30, 2024
@MicahGale MicahGale marked this pull request as ready for review October 30, 2024 17:12
@MicahGale MicahGale added CI/CD critical An issue that seriously limits user adoption or hampers current use. labels Oct 30, 2024
@MicahGale MicahGale merged commit 9e77f4f into main Oct 30, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@MicahGale MicahGale

Labels
bugs A deviation from expected behavior that does not reach the level of being reportable as an "Error". CI/CD critical An issue that seriously limits user adoption or hampers current use. parsers are hard Examples of where MCNP syntax is complicated and should be simplified.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MicahGale @tjlaboss