-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug with how new material components are exported. #598
Merged
MicahGale
merged 11 commits into
develop
from
597-montepy-is_atomic_fraction-does-not-work-as-expected
Dec 11, 2024
Merged
Fix bug with how new material components are exported. #598
MicahGale
merged 11 commits into
develop
from
597-montepy-is_atomic_fraction-does-not-work-as-expected
Dec 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MicahGale
added
bugs
A deviation from expected behavior that does not reach the level of being reportable as an "Error".
critical
An issue that seriously limits user adoption or hampers current use.
labels
Dec 2, 2024
@AlphonseM91 could you check the updated test in this PR to see if you think this test is effective for replicating #597, or if you have any other tests you think should be included? |
@tjlaboss, when you are back, please review this one first. We need to release 0.5.3 ASAP. |
tjlaboss
reviewed
Dec 10, 2024
tjlaboss
approved these changes
Dec 11, 2024
MicahGale
deleted the
597-montepy-is_atomic_fraction-does-not-work-as-expected
branch
December 11, 2024 14:37
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist for MontePy
Description
This fixes a bug that made it so that added componenents are not properly exported in multiple ways. The ways it broke:
is_atom_fraction
was not reflected in the sign of the fractions on export.Fixes:
is_negative
attribute for all fractions on export.Fixes #597
General Checklist
Documentation Checklist
I have documented all added classes and methods.For infrastructure updates, I have updated the developer's guide.For significant new features, I have added a section to the getting started guide.First-Time Contributor Checklist
If this is your first contribution, add yourself topyproject.toml
if you wish to do so.Additional Notes for Reviewers
Ensure that:
"""