Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the example with the "useless use of echo" and backticks #293

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Strahinja
Copy link

One of the examples on the front page,

file=$(echo `basename "$file"`)

is using the deprecated backticks and "useless use of echo". As explainshell.com is likely to be used for learning shell, this potentially teaches those bad habits.

This PR changes the example to

name=$(printf "%s@%s" "$(id -nu)" "$(uname -n)")

…milar

Signed-off-by: Страхиња Радић <contact@strahinja.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant