-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
landing page updates #81
base: trunk
Are you sure you want to change the base?
Conversation
Important Auto Review SkippedDraft detected. Please check the settings in the CodeRabbit UI or the To trigger a single review, invoke the TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Files ignored due to filter (4)
- libs/carrier-portal/landing-page/project.json
- libs/carrier-portal/landing-page/tsconfig.json
- libs/carrier-portal/landing-page/tsconfig.lib.json
- libs/carrier-portal/landing-page/tsconfig.spec.json
Files selected for processing (4)
- libs/carrier-portal/shell/src/lib/library.routes.ts (2 hunks)
- libs/console/shell/src/lib/shell/shell.component.html (1 hunks)
- libs/console/shell/src/lib/shell/shell.component.scss (2 hunks)
- libs/shared/theme/src/lib/styles/partials/_color.scss (2 hunks)
Files skipped from review due to trivial changes (3)
- libs/console/shell/src/lib/shell/shell.component.html
- libs/console/shell/src/lib/shell/shell.component.scss
- libs/shared/theme/src/lib/styles/partials/_color.scss
Additional comments (Suppressed): 2
libs/carrier-portal/shell/src/lib/library.routes.ts (2)
- 12-15: The root path ('') is now loading the 'member-search' module instead of the 'carrierPortalLandingPageRoutes' module. Ensure that this change does not affect the expected behavior and navigation of the application.
- path: '', + path: 'member-search',
- 31-34: The route for loading the 'carrierPortalLandingPageRoutes' module at the root path ('') has been removed. If this was intentional, ensure that there are no broken references or links due to this removal. If it was unintentional, consider adding it back.
+ { + path: '', + loadChildren: () => + import('@enroll/carrier-portal/landing-page').then( + (m) => m.carrierPortalLandingPageRoutes + ), + canActivate: [AuthGuard], + },
@alexrekas |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, will be interested to see it live when merged. thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Files selected for processing (1)
- libs/carrier-portal/member-search/src/lib/member-search/member-search.component.html (1 hunks)
Files skipped from review due to trivial changes (1)
- libs/carrier-portal/member-search/src/lib/member-search/member-search.component.html
Signed-off-by: Brad Bodine <bbodine1@gmail.com>
Summary by CodeRabbit
Release Notes for Pull Request: