Fix zkEVM blockchains and add Linea blockchains #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daveroga
changed the title
daveroga
changed the title
daveroga
changed the title
src/constants.ts
Outdated
| @@ -97,13 +101,15 @@ const blockchainNetworkMap = { | |||
| [`${Blockchain.Polygon}:${NetworkId.Main}`]: 0b0001_0000 | 0b0000_0001, | |||
| [`${Blockchain.Polygon}:${NetworkId.Mumbai}`]: 0b0001_0000 | 0b0000_0010, | |||
| [`${Blockchain.Polygon}:${NetworkId.Amoy}`]: 0b0001_0000 | 0b0000_0011, | |||
| [`${Blockchain.Polygon}:${NetworkId.Zkevm}`]: 0b0011_0000 | 0b0000_0001, | |||
There was a problem hiding this comment.
we shouldn't change Blockchain bytes, for Polygon it's 0b0001_0000, you need to change NetworkId flag
There was a problem hiding this comment.
Or we shouldn't change networkFlag to not break anything ?
CC @vmidyllic
There was a problem hiding this comment.
we could set it like this 0b0001_0000 | 0b0010_0001,
so first 4 bits would be the same as other Polygon and in netwrok we will keep final version of networkFlag as it was
There was a problem hiding this comment.
Values should match golang ones:
{Blockchain: Polygon, NetworkID: Zkevm}: 0b0001_0000 | 0b0000_0100,
{Blockchain: Polygon, NetworkID: Cardona}: 0b0001_0000 | 0b0000_0101,There was a problem hiding this comment.
volodymyr-basiuk
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix zkevm blockchains
Add Linea blockchains