Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation: Examples #113

Merged
merged 3 commits into from
Feb 11, 2024
Merged

Documentation: Examples #113

merged 3 commits into from
Feb 11, 2024

Conversation

gregwht
Copy link
Collaborator

@gregwht gregwht commented Feb 2, 2024

Producing further examples for:

  • ASREnvelope
  • Line
  • AllPassDelay
  • CombDelay
  • EQ
  • SVFilter
  • StereoBalance
  • StereoPanner
  • WhiteNoise

Producing further examples for:
* ASREnvelope
* Line
* AllPassDelay
* CombDelay
* EQ
* SVFilter
* StereoBalance
* StereoPanner
* WhiteNoise
Copy link
Owner

@ideoforms ideoforms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely loving the new examples! A few comments inline.

docs/library/processors/delays/allpassdelay/example-0.py Outdated Show resolved Hide resolved
docs/library/processors/delays/allpassdelay/example-1.py Outdated Show resolved Hide resolved
docs/library/processors/panning/stereobalance/example-0.py Outdated Show resolved Hide resolved
docs/library/stochastic/whitenoise/example-0.py Outdated Show resolved Hide resolved
* Improving QOL for oscillator examples by making them stereo and reducing volume -- let me know if this should be done differently?
* Making formatting more consistent across examples
* For node classes with more arguments, explicitly typing them out to help the reader understand
Adding examples for ChannelArray, OneTapDelay, Resample, StereoWidth.
Updating documentation for Line.
Copy link
Owner

@ideoforms ideoforms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great!

@ideoforms ideoforms merged commit 9dacb89 into master Feb 11, 2024
1 check passed
@ideoforms ideoforms deleted the docs/examples branch February 11, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants