Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stale check desktop issue1064 #6

Merged
merged 1 commit into from
May 21, 2024
Merged

stale check desktop issue1064 #6

merged 1 commit into from
May 21, 2024

Conversation

aceppaluni
Copy link
Member

The Pull Request is ready

  • fixes #issue1064
  • all actions are passing
  • only fixes a single issue

Overview

Add stale check to desktop

Review points

Added a new yml file to accommodate stale check
File placed in workflows

Desktop

  • the change can be packaged
  • the default behaviour did not change
  • shared code has been extracted in a different file

Notes

Issue associated with issue#1064

Copy link

coderabbitai bot commented May 21, 2024

Walkthrough

CodeRabbitAI observes the introduction of a GitHub Actions workflow named "Stale". This workflow automates the management of stale issues and pull requests. It includes steps to close inactive PRs and issues, unassign contributors, and notify about these actions. The workflow ensures repository maintenance by handling inactivity efficiently.

Changes

Files Change Summary
.github/workflows/cron.stale.yml Added the "Stale" workflow to manage stale issues and pull requests. Configured actions for closing and unassigning.

In the repository, a cycle begins,
Stale issues close, no more chagrin.
Contributors freed from tasks long cold,
Automation's touch, efficient and bold.
CodeRabbitAI sees, the changes unfold,
A tidy repo, a story retold.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

Note: Auto-reply has been disabled for this repository by the repository owner. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing!
Please make sure the actions pass. Once your pull request has been merged, you will automatically be added to the contributor's list on the website.
If you want to be shouted out on Linkedin, have a look for the shoutout issue of the specific version.

You can also find us on slack at idrinth-api-bench.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

Review Details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits Files that changed from the base of the PR and between 28f30d9 and 903c1fd.
Files selected for processing (1)
  • .github/workflows/cron.stale.yml (1 hunks)
Additional comments not posted (1)
.github/workflows/cron.stale.yml (1)

22-27: CodeRabbit confirms that the configuration for the 'remove-assignee' job is correctly set up and adheres to the intended functionality as described in the PR objectives.

Comment on lines +10 to +20
runs-on: ubuntu-latest
steps:
- uses: actions/stale@v9
with:
days-before-pr-stale: 7
days-before-issue-stale: 7
close-pr-message: "Due to lack of activity this has been closed for now. Feel free to reopen once you are back."
include-only-assigned: true
days-before-issue-close: 21
stale-issue-message: "Due to inactivity you will be unassigned soon and the issue be freed."
exempt-issue-labels: "shoutout"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeRabbit observes that the configuration for the 'stale' job is logically sound and follows best practices for GitHub Actions. However, the message in line 19 might be improved for clarity.

- "Due to inactivity you will be unassigned soon and the issue be freed."
+ "Due to inactivity, you will be unassigned soon, and the issue will be made available for others."

Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.

Suggested change
runs-on: ubuntu-latest
steps:
- uses: actions/stale@v9
with:
days-before-pr-stale: 7
days-before-issue-stale: 7
close-pr-message: "Due to lack of activity this has been closed for now. Feel free to reopen once you are back."
include-only-assigned: true
days-before-issue-close: 21
stale-issue-message: "Due to inactivity you will be unassigned soon and the issue be freed."
exempt-issue-labels: "shoutout"
runs-on: ubuntu-latest
steps:
- uses: actions/stale@v9
with:
days-before-pr-stale: 7
days-before-issue-stale: 7
close-pr-message: "Due to lack of activity this has been closed for now. Feel free to reopen once you are back."
include-only-assigned: true
days-before-issue-close: 21
stale-issue-message: "Due to inactivity, you will be unassigned soon, and the issue will be made available for others."
exempt-issue-labels: "shoutout"

@Idrinth Idrinth marked this pull request as ready for review May 21, 2024 17:04
@Idrinth Idrinth merged commit 0653c7e into the-one May 21, 2024
2 of 7 checks passed
@Idrinth Idrinth deleted the jul-contribute branch May 21, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants