add inline option to embeded struct's json tag #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuqi-zhang
added a commit
to yuqi-zhang/machine-config-operator
that referenced
this pull request
Feb 18, 2020
Following https://github.com/openshift/api#generating-crd-schemas, add in ability to generate CRD schemas. Note that this currently does not work pending idubinskiy/schematyper#18 Signed-off-by: Yu Qi Zhang <jerzhang@redhat.com>
|
Ping @idubinskiy. Any chance you could review (and eventually merge) this soonish? |
|
would be great to get this merged |
JAORMX
approved these changes
Mar 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Embedded structs are generated without any explicit json tag, leaving the interpretation of the embedded struct ambiguous. Adding the
inlineoption to the embedded struct's json tag.