Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Agenda proposed badge #8164

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Conversation

holloway
Copy link
Contributor

@holloway holloway commented Nov 6, 2024

  • Adds a grey 'Proposed' badge to sessions with a state of proposed.
    Screenshot from 2024-11-15 09-14-37
  • In dark mode darkens the 'BoF' badge to make it more readable. Before: Screenshot from 2024-11-06 10-49-49. After: Screenshot from 2024-11-06 10-48-43 .

fixes #8026

Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.93%. Comparing base (c7f6bde) to head (6c2bb07).
Report is 182 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8164      +/-   ##
==========================================
+ Coverage   88.78%   88.93%   +0.15%     
==========================================
  Files         296      303       +7     
  Lines       41320    41260      -60     
==========================================
+ Hits        36687    36696       +9     
+ Misses       4633     4564      -69     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rjsparks
Copy link
Member

@cindymorgan : help us develop the right popup text?

@cindymorgan
Copy link
Collaborator

Suggest:

Proposed WGs are groups in the process of being chartered. If the charter is not approved by the IESG before the IETF meeting, the session may be canceled.

@holloway holloway marked this pull request as ready for review November 14, 2024 18:30
@holloway
Copy link
Contributor Author

@rjsparks hah, I'd DMd Cindy yesterday to follow up about this too

@rjsparks rjsparks merged commit c89646e into ietf-tools:main Nov 14, 2024
9 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a "Proposed" flag on https://datatracker.ietf.org/meeting/agenda for WGs that haven't completed chartering
3 participants