Merge pull request #214 from ifad/chore/add-rubocop-to-production-code

Add RuboCop to production code - Stage I
ifad · Sep 9, 2023 · b927ceb · b927ceb
2 parents d3ac229 + 910eae8
commit b927ceb
Show file tree

Hide file tree

Showing 25 changed files with 815 additions and 501 deletions.
diff --git a/.gitattributes b/.gitattributes
@@ -0,0 +1 @@
+.rubocop_todo.yml linguist-generated
diff --git a/.rubocop.yml b/.rubocop.yml
@@ -1,3 +1,5 @@
+inherit_from: .rubocop_todo.yml
+
 require:
   - rubocop-packaging
   - rubocop-performance
@@ -11,17 +13,14 @@ AllCops:
   TargetRubyVersion: 2.2
   Exclude:
     - 'gemfiles/**/*'
-    - 'lib/**/*'
     - 'vendor/bundle/**/*'
     - 'tmp/**/*'
 
 Gemspec/DevelopmentDependencies:
   Enabled: false
 
 Layout/LineLength:
-  Max: 140
-  Exclude:
-    - 'spec/**/*'
+  Enabled: false
 
 Lint/MissingSuper:
   Exclude:
@@ -40,6 +39,15 @@ Metrics/MethodLength:
   Exclude:
     - 'spec/**/*'
 
+Naming/MethodName:
+  AllowedPatterns:
+    - '_INSERT_'
+    - '_UPDATE_'
+    - '_DELETE_'
+
+Naming/PredicateName:
+  Enabled: false
+
 Rails/ApplicationRecord:
   Enabled: false
 
@@ -75,6 +83,9 @@ Style/GlobalVars:
   Exclude:
     - 'spec/**/*'
 
+Style/IfUnlessModifier:
+  Enabled: false
+
 # NOTE: This cop is enabled by RuboCop Rails, because active support adds this
 # method to hash, but `except` is not available in specs
 Style/HashExcept:

diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml