Feature/spherical harmonics #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much for this pull request. I appreciate the contribution! I will need a bit of time to process it all before I can approve it. I'll make sure to let you know. |
ifilot
added a commit
that referenced
this pull request
Sep 12, 2024
* Initial commit new compilation procedure * Feature/spherical harmonics (#39) * add coefficients for spherical harmonics * add spherica gto * also add test * more docs * test for valid input --------- Co-authored-by: Moritz Gubler <moritz.gubler@e.email> * Incrementing version number * Changing names --------- Co-authored-by: moritzgubler <moritz.gubler@gmail.com> Co-authored-by: Moritz Gubler <moritz.gubler@e.email>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
I used Horton: documentation, conversion tool to construct the conversion coefficients from cartesian to spherical gaussian orbitals.
Using these coefficients I implemented
def add_spherical_gto(self, c, alpha, l, m):inpyqint/cgf.pywhich adds a normalized, real spherical harmonic function. I also added a test intests/test_cgf.pywhere I check if the overlap matrix of all spherical gaussian orbitals is the identity matrix which it is.Let me know if you also like this feature or if you have any other suggestions for improving this feature.