Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add eslint fix #21

Merged
merged 3 commits into from
Nov 27, 2024
Merged

Add eslint fix #21

merged 3 commits into from
Nov 27, 2024

Conversation

T1B0
Copy link
Collaborator

@T1B0 T1B0 commented Nov 26, 2024

  • update README.md
  • add eslint 9
  • fix lint issues

@T1B0 T1B0 requested review from spetz and Tchoupinax November 26, 2024 21:37
Tchoupinax
Tchoupinax previously approved these changes Nov 26, 2024
View reviewed changes
Copy link
Collaborator

@Tchoupinax Tchoupinax left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lines are commented, if you agree it's expected, LGTM!

@T1B0
Copy link
Collaborator Author

T1B0 commented Nov 26, 2024 •
edited
Loading

@Tchoupinax @spetz please note semantic release prefer squash or rebase merge, as merge commit just polute history uselessly 🙏

@spetz
Copy link
Contributor

spetz commented Nov 27, 2024

@Tchoupinax @spetz please note semantic release prefer squash or rebase merge, as merge commit just polute history uselessly 🙏

Yes, I've only made it available to use squash merge anyway :)

@spetz spetz merged commit 044270d into main Nov 27, 2024
2 checks passed
@spetz spetz deleted the add-eslint-fix branch November 27, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spetz spetz spetz approved these changes

@Tchoupinax Tchoupinax Tchoupinax left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@T1B0 @spetz @Tchoupinax