Skip to content

Commit

Permalink
ci: remove outdated rule
Browse files Browse the repository at this point in the history
  • Loading branch information
Tchoupinax committed Dec 15, 2024
1 parent 85351ec commit 1885011
Showing 1 changed file with 4 additions and 25 deletions.
29 changes: 4 additions & 25 deletions .github/workflows/sanity.yml
Original file line number Diff line number Diff line change
Expand Up @@ -68,33 +68,12 @@ jobs:
- name: Check subject line length
uses: gsactions/commit-message-checker@v2
with:
excludeDescription: 'false' # exclude description body of a pull request
excludeTitle: 'false' # exclude the title of a pull request
checkAllCommitMessages: 'false' # checks all commits associated with the pull request
excludeDescription: "false" # exclude description body of a pull request
excludeTitle: "false" # exclude the title of a pull request
checkAllCommitMessages: "false" # checks all commits associated with the pull request
accessToken: ${{ secrets.GITHUB_TOKEN }} # needed only when checkAllCommitMessages is true
pattern: '^.{0,80}(\n.*)*$'
error: 'Subject of all commits in the PR and PR body/title has to be shorter than 80 characters.'

- name: Disallow specific prefixes in title
uses: gsactions/commit-message-checker@v2
with:
excludeDescription: 'true'
excludeTitle: 'true'
checkAllCommitMessages: 'true'
accessToken: ${{ secrets.GITHUB_TOKEN }}
pattern: '^(?!(.*(feat|fix|docs|style|refactor|perf|test|chore):.*(\n.*)*$)).*'
error: 'Do not use prefixes like "feat:", "fix:", etc., in the subject of any commit in the PR.'

- name: Disallow lowercase subject
uses: gsactions/commit-message-checker@v2
with:
excludeDescription: 'true'
excludeTitle: 'false'
checkAllCommitMessages: 'false'
accessToken: ${{ secrets.GITHUB_TOKEN }}
pattern: '^[A-Z].*(\n.*)*$'
error: 'Subject of title in the PR has to start with a capital letter.'

error: "Subject of all commits in the PR and PR body/title has to be shorter than 80 characters."
# Uncomment this when we have a proper release - 1.0.0
# semver-checks:
# name: SemVer SDK
Expand Down

0 comments on commit 1885011

Please sign in to comment.