Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ResultContext with ErrContext in error_set usage #1410

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

hubcio
Copy link
Collaborator

@hubcio hubcio commented Dec 30, 2024

No description provided.

numinnex
numinnex previously approved these changes Dec 30, 2024
@hubcio hubcio force-pushed the err-context-deprecation branch 2 times, most recently from 9936028 to 58c49a9 Compare December 31, 2024 10:19
@hubcio hubcio force-pushed the err-context-deprecation branch from 58c49a9 to bfcd319 Compare December 31, 2024 10:40
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 12558601592

Details

  • 331 of 532 (62.22%) changed or added relevant lines in 89 files are covered.
  • 21 unchanged lines in 12 files lost coverage.
  • Overall coverage decreased (-0.1%) to 75.327%

Changes Missing Coverage Covered Lines Changed/Added Lines %
server/src/binary/handlers/consumer_groups/join_consumer_group_handler.rs 0 1 0.0%
server/src/binary/handlers/consumer_groups/leave_consumer_group_handler.rs 0 1 0.0%
server/src/binary/handlers/messages/flush_unsaved_buffer_handler.rs 0 1 0.0%
server/src/binary/handlers/streams/create_stream_handler.rs 1 2 50.0%
server/src/binary/handlers/streams/get_streams_handler.rs 2 3 66.67%
server/src/binary/handlers/system/get_clients_handler.rs 2 3 66.67%
server/src/binary/handlers/system/get_me_handler.rs 2 3 66.67%
server/src/binary/handlers/system/ping_handler.rs 2 3 66.67%
server/src/binary/handlers/topics/create_topic_handler.rs 1 2 50.0%
server/src/binary/handlers/users/change_password_handler.rs 1 2 50.0%
Files with Coverage Reduction New Missed Lines %
server/src/configs/tcp.rs 1 0.0%
server/src/configs/quic.rs 1 0.0%
sdk/src/models/messages.rs 1 66.23%
sdk/src/consumer.rs 1 45.31%
sdk/src/models/header.rs 1 91.32%
server/src/configs/http.rs 1 66.67%
sdk/src/messages/poll_messages.rs 1 83.54%
server/src/configs/validators.rs 1 56.48%
server/src/streaming/topics/consumer_offsets.rs 2 93.1%
sdk/src/messages/send_messages.rs 2 82.3%
Totals Coverage Status
Change from base Build 12548248698: -0.1%
Covered Lines: 24204
Relevant Lines: 32132

💛 - Coveralls

@hubcio hubcio merged commit 68fe698 into master Dec 31, 2024
17 checks passed
@hubcio hubcio deleted the err-context-deprecation branch December 31, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants