Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open images in a light box #81

Open
allanday opened this issue Jul 27, 2015 · 4 comments
Open

Open images in a light box #81

allanday opened this issue Jul 27, 2015 · 4 comments
Assignees
Milestone

Comments

@allanday
Copy link
Collaborator

Currently, when you click on an image, it is opened in a browser tab. It would be better to display the image in News instead, using a light box.

There's a wireframe for this in the mockups:

https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/news/news-wires.png

@ignatenkobrain ignatenkobrain self-assigned this Jul 27, 2015
@ignatenkobrain ignatenkobrain added this to the 3.18 milestone Jul 27, 2015
ignatenkobrain added a commit that referenced this issue Jul 27, 2015
light box is not implemented, but now we have list of images
(we can have backward/forward working) and image uri which clicked

Reference: #81
Signed-off-by: Igor Gnatenko <ignatenko@src.gnome.org>
@ignatenkobrain
Copy link
Owner

@mcatanzaro I've implemented handling image clicks in 0d282fd. Probably this might be extension, but I have noe experience how to write it. How code looks for you ?

@brunelli
Copy link

@allanday Is there a specific widget for a lightbox, or it would be just a custom GtkDialog, or something done with HTML5? (Just for the sake of curiosity, because I'm implementing something similar in one of my projects...)

@felipeborges
Copy link
Collaborator

@ianbrunelli there's no specific widget for that in Gtk, but that could be easily written using GtkOverlay. I've written this snippet to show what I have in mind: https://gist.github.com/felipeborges/01d1097b3beddc81e8b6 of course it'd be way more polished in a real life implementation.

P.S. (in case you can't run the snippet) screencast from 08-11-2015 10-05-21 pm

@brunelli
Copy link

@felipeborges Very nice. It will indeed be a good addition to News.

I don't think that's the solution that better fits my app, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants