You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
light box is not implemented, but now we have list of images
(we can have backward/forward working) and image uri which clicked
Reference: #81
Signed-off-by: Igor Gnatenko <ignatenko@src.gnome.org>
@mcatanzaro I've implemented handling image clicks in 0d282fd. Probably this might be extension, but I have noe experience how to write it. How code looks for you ?
@allanday Is there a specific widget for a lightbox, or it would be just a custom GtkDialog, or something done with HTML5? (Just for the sake of curiosity, because I'm implementing something similar in one of my projects...)
@ianbrunelli there's no specific widget for that in Gtk, but that could be easily written using GtkOverlay. I've written this snippet to show what I have in mind: https://gist.github.com/felipeborges/01d1097b3beddc81e8b6 of course it'd be way more polished in a real life implementation.
Currently, when you click on an image, it is opened in a browser tab. It would be better to display the image in News instead, using a light box.
There's a wireframe for this in the mockups:
https://raw.githubusercontent.com/gnome-design-team/gnome-mockups/master/news/news-wires.png
The text was updated successfully, but these errors were encountered: