Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: expose chain-registry structs #4472

Merged
merged 6 commits into from
Jan 16, 2025
Merged

feat: expose chain-registry structs #4472

merged 6 commits into from
Jan 16, 2025
+230 −183

Conversation

julienrbrt
Copy link
Member

This PR exposes the chain registry structs that were recently added.
This package will then be used by Ignite Connect app to avoid duplication (ignite/apps#102)

@julienrbrt julienrbrt added skip-changelog Don't check changelog for new entries backport/v28.x.y Backport to v28.x.y labels Jan 15, 2025
@julienrbrt julienrbrt requested a review from salmad3 January 15, 2025 23:29
@github-actions github-actions bot added component:ci CI/CD workflow and automated jobs. component:configs type:services Service-related issues. component:packages labels Jan 15, 2025
salmad3
salmad3 approved these changes Jan 16, 2025
View reviewed changes
Copy link
Member

@salmad3 salmad3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An enhancement could be to unify the JSON serialization into a single shared function (e.g., SaveAsJSON) and call it from each struct’s method

@julienrbrt
Copy link
Member Author

An enhancement could be to unify the JSON serialization into a single shared function (e.g., SaveAsJSON) and call it from each struct’s method

I don't really get the advantage. For connect for instance we just need the struct, and in CLI calling them separately is fine right

@julienrbrt julienrbrt merged commit ec26e2e into main Jan 16, 2025
42 of 45 checks passed
@julienrbrt julienrbrt deleted the julien/expose-chainregistry-strucs branch January 16, 2025 06:34
mergify bot pushed a commit that referenced this pull request Jan 16, 2025
@julienrbrt @mergify
feat: expose chain-registry structs (#4472)
516194c 
* feat: expose chain-registry structs

* updates

* split

* structure

* updates

* lint

(cherry picked from commit ec26e2e)

# Conflicts:
#	ignite/services/scaffolder/chain_registry.go
@mergify mergify bot mentioned this pull request Jan 16, 2025
Merged
julienrbrt added a commit that referenced this pull request Jan 16, 2025
@mergify @julienrbrt
feat: expose chain-registry structs (backport #4472) (#4473)
fcf01a4 
* feat: expose chain-registry structs (#4472)

* feat: expose chain-registry structs

* updates

* split

* structure

* updates

* lint

(cherry picked from commit ec26e2e)

# Conflicts:
#	ignite/services/scaffolder/chain_registry.go

* conflict

---------

Co-authored-by: Julien Robert <julien@rbrt.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@salmad3 salmad3 salmad3 approved these changes

@ilgooz ilgooz Awaiting requested review from ilgooz ilgooz is a code owner

@jeronimoalbi jeronimoalbi Awaiting requested review from jeronimoalbi jeronimoalbi is a code owner

@Pantani Pantani Awaiting requested review from Pantani Pantani is a code owner

Assignees

@julienrbrt julienrbrt

Labels
backport/v28.x.y Backport to v28.x.y component:ci CI/CD workflow and automated jobs. component:configs component:packages skip-changelog Don't check changelog for new entries type:services Service-related issues.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julienrbrt @salmad3