Code refresh and cleanup

[stokito]

Small changes to make IntellJ inspections happy.
I also updated the EXI library to the latest version. From the changelog it looks like there are some changes to migrate to Java 8.
Anyway the plugin needs for a regression testing so will see if the new version is fine.
I'll try later to migrate it to the latest Openfire but not sure if I can do this.

[guusdk]

Thanks for this!

Have you checked that the Base64 implementation that is being replaced is functionally equal to its replacement? If I recall correctly, there are a couple of flavors that differ in small ways.

[stokito]

Have you checked that the Base64 implementation that is being replaced is functionally equal to its replacement?

yes, this is same Base64, not the Base64-URL

[guusdk]

Heh, that's a nice trick. :)

[stokito]

Yeah, but it's still questionable if it worth using. Unfortunately you can't make something like ${project.developers[*].name} to list all developer names. You can use ${project.developers} that will print [Developer {id=null, Contributor {name=Javier Placencio, email=null}}, Developer {id=null, Contributor {name=Guus der Kinderen, email=guus.der.kinderen@gmail.com}}].
Maybe in future Maven releases this will improved somehow.

[guusdk]

This looks perfectly fine to me, thank! Can you add a changelog entry to reflect the changes please? Maybe bump up the version number if you feel that this warrants a more-than-a-patch-release increase.

[guusdk]

Oh, I only now see the build fail. Did you use Java API that's not available in Java 8 yet, maybe?

[stokito]

Yes, sorry, I used the ByteArrayOutputStream.toString(Charset) from Java 10. I downgraded it back to ByteArrayOutputStream.toString(String).
Also added changelog entry