Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add step to locate plugin.xml #8

Merged
merged 2 commits into from
Nov 26, 2023
Merged

feat: add step to locate plugin.xml #8

merged 2 commits into from
Nov 26, 2023

Conversation

akrherz
Copy link
Member

@akrherz akrherz commented Nov 23, 2023

No description provided.

@Fishbowler
Copy link
Member

Should we go further and error explicitly if the file isn't found, or is found in the wrong place?

@akrherz
Copy link
Member Author

akrherz commented Nov 23, 2023

Should we go further and error explicitly if the file isn't found, or is found in the wrong place?

Good idea, pushed a new commit.

@akrherz
Copy link
Member Author

akrherz commented Nov 26, 2023

This PR worked with igniterealtime/openfire-exi-plugin#1, can we take it here now?

@Fishbowler Fishbowler merged commit 99e7c0b into igniterealtime:main Nov 26, 2023
@akrherz akrherz deleted the hacky branch November 26, 2023 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fishbowler Fishbowler Fishbowler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akrherz @Fishbowler