Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes compatibility issue with Openfire 4.9.0 #201

Merged

Conversation

guusdk
Copy link
Member

@guusdk guusdk commented Oct 4, 2024

This replaces API of Openfire that was removed in Openfire 4.9.0. The plugin remains compatible with Openfire 4.8.0 and later.

Fixes #200

This replaces API of Openfire that was removed in Openfire 4.9.0. The plugin remains compatible with Openfire 4.8.0 and later.

Fixes igniterealtime#200
@Fishbowler
Copy link
Member

Is there a way to CI our way to detecting things like this?

@guusdk
Copy link
Member Author

guusdk commented Oct 5, 2024

I would love to find a way to automatically detect issues like this, not just for this plugin, but also for all other plugins. Lets discuss that not in scope of just this RESTAPI issue. I've created a new ticket here: igniterealtime/ci-tooling#1

Copy link
Member

@Fishbowler Fishbowler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on my machine.
Can get into settings, configure for shared key auth, and have fired a sample of GET requests.

@guusdk guusdk merged commit ae85c60 into igniterealtime:main Oct 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

API plugin - Openfire 4.0.9.0 - Missing Session Status STATUS_CLOSED
2 participants