This repository has been archived by the owner on Nov 22, 2022. It is now read-only.
Add support for EXT-X-MAP and EXT-X-BYTERANGE #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wopple
reviewed
Oct 9, 2017
|
|
||
| public class ByteRange { | ||
| private final long mSubRangeLength; | ||
| private final Long mOffset; |
There was a problem hiding this comment.
Please use a primitive, see IFrameStreamInfo.getAverageBandwidth as an example.
There was a problem hiding this comment.
Actually, there is no null case for the offset. I'll refer to my comment here:
Wopple
reviewed
Oct 9, 2017
| @Override | ||
| public boolean equals(Object o) { | ||
| if (this == o) return true; | ||
| if (o == null || getClass() != o.getClass()) return false; |
There was a problem hiding this comment.
Though I don't think it makes a functional difference, the other data classes have been using instanceof for the type check.
|
All in all, nice work! The offset is a little nuanced and difficult to handle, but once that gets updated this should be good to merge. |
|
When will this be released? I see that last release was 0.2.6 (Jan 2017). Thanks. Or should I switch to the carlanton/m3u8-parser? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some of the byte range issues discussed in #47 + support for EXT-X-MAP.