Add changes in peer dependencies for RN 64+ #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since version 64 of react-native, the react version is set to 17 and we have versions mismatch when use react-native-scalable-image. So change react peer dependency and remove prop-types peer dependency
|
Please consider this pull request for merging |
|
+1, currently impossible to npm install react-native-fit-image in the latest version of RN. |
|
@TheWebartist Why did you remove |
okansarica
approved these changes
Jan 20, 2022
|
There is a fork that already merged this PR here if you need this to work after upgrading RN: https://github.com/uugengiven/react-native-scalable-image |
|
Any updates for this? |
|
any updates? |
|
I also need this change. Any updates? |
|
#41 check this one it might help you , I just got the same problem ( i'm working with react 18 ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since version 64 of react-native, the react version is set to 17 and we have versions mismatch when use react-native-scalable-image. So change react peer dependency and remove prop-types peer dependency