Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of multiple pairings #456

Merged
merged 14 commits into from
Oct 4, 2023
Merged

Conversation

bdraco
Copy link
Contributor

@bdraco bdraco commented Sep 28, 2023

We were missing the separators between pairings for list pairings which made iOS confused

This should fix pairing with iOS 17 as well as secondary users not being able to use the bridge for iOS 17 and older.

@codecov
Copy link

codecov bot commented Sep 28, 2023

Codecov Report

Merging #456 (a35513a) into dev (5f45a5e) will increase coverage by 0.61%.
The diff coverage is 93.33%.

@@            Coverage Diff             @@
##              dev     #456      +/-   ##
==========================================
+ Coverage   91.64%   92.26%   +0.61%     
==========================================
  Files          20       20              
  Lines        2191     2198       +7     
  Branches      276      278       +2     
==========================================
+ Hits         2008     2028      +20     
+ Misses        139      124      -15     
- Partials       44       46       +2     
Files Coverage Δ
pyhap/params.py 100.00% <ø> (ø)
pyhap/state.py 100.00% <100.00%> (ø)
pyhap/tlv.py 100.00% <100.00%> (ø)
pyhap/hap_handler.py 86.18% <90.90%> (+5.05%) ⬆️

... and 1 file with indirect coverage changes

@bdraco bdraco changed the title Improve pair verify handling Fix handling of multiple pairings Sep 28, 2023
@bdraco bdraco marked this pull request as ready for review October 3, 2023 11:20
@ikalchev ikalchev merged commit 767d752 into ikalchev:dev Oct 4, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants