Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some more typing characteristics and services #463

Merged
merged 5 commits into from
Oct 14, 2023

Conversation

bdraco
Copy link
Contributor

@bdraco bdraco commented Oct 10, 2023

will conflict with #462 so it should merge first

@codecov
Copy link

codecov bot commented Oct 10, 2023

Codecov Report

Merging #463 (34f1104) into dev (f95cd15) will increase coverage by 0.11%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev     #463      +/-   ##
==========================================
+ Coverage   92.36%   92.48%   +0.11%     
==========================================
  Files          20       20              
  Lines        2228     2223       -5     
  Branches      278      274       -4     
==========================================
- Hits         2058     2056       -2     
+ Misses        124      123       -1     
+ Partials       46       44       -2     
Files Coverage Δ
pyhap/accessory.py 97.33% <100.00%> (+0.62%) ⬆️
pyhap/characteristic.py 100.00% <100.00%> (ø)
pyhap/hap_crypto.py 100.00% <100.00%> (ø)
pyhap/hap_handler.py 86.64% <100.00%> (+0.36%) ⬆️
pyhap/service.py 100.00% <100.00%> (ø)
pyhap/util.py 92.68% <100.00%> (ø)

@bdraco bdraco marked this pull request as ready for review October 11, 2023 19:03
@ikalchev ikalchev merged commit 07df76b into ikalchev:dev Oct 14, 2023
10 checks passed
@bdraco bdraco deleted the typing branch October 14, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants