Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small cleanups to the protocol handler #465

Merged
merged 3 commits into from
Oct 14, 2023

Conversation

bdraco
Copy link
Contributor

@bdraco bdraco commented Oct 12, 2023

needs #463 first

  • Add some typing
  • Avoid some bytes concat

- Add some typing
- Avoid some bytes concat
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #465 (a243126) into dev (07df76b) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              dev     #465      +/-   ##
==========================================
+ Coverage   92.48%   92.50%   +0.01%     
==========================================
  Files          20       20              
  Lines        2223     2227       +4     
  Branches      274      274              
==========================================
+ Hits         2056     2060       +4     
  Misses        123      123              
  Partials       44       44              
Files Coverage Δ
pyhap/hap_event.py 100.00% <100.00%> (ø)
pyhap/hap_handler.py 86.64% <100.00%> (ø)
pyhap/hap_protocol.py 99.39% <100.00%> (+0.01%) ⬆️

@bdraco bdraco marked this pull request as ready for review October 12, 2023 20:27
@ikalchev ikalchev merged commit 7d5fc4d into ikalchev:dev Oct 14, 2023
10 checks passed
@bdraco bdraco deleted the hap_proto_cleanups branch October 14, 2023 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants