plugins/micron: Fix code scanning alert

Fix the time-of-check time-of-use filesystem race condition. Signed-off-by: Tokunori Ikegami <ikegami.t@gmail.com>
ikegami-t · Feb 11, 2024 · d9529f2 · d9529f2
1 parent 83aad43
commit d9529f2
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/plugins/micron/micron-nvme.c b/plugins/micron/micron-nvme.c
@@ -319,7 +319,8 @@ static int SetupDebugDataDirectories(char *strSN, char *strFilePath,
 	if (strOSDirName) {
 		sprintf(strOSDirName, "%s/%s", strMainDirName, "OS");
 		if (mkdir(strOSDirName, 0777) < 0) {
-			rmdir(strMainDirName);
+			if (strMainDirName)
+				rmdir(strMainDirName);
 			err = -1;
 			goto exit_status;
 		}
@@ -329,9 +330,10 @@ static int SetupDebugDataDirectories(char *strSN, char *strFilePath,
 		if (mkdir(strCtrlDirName, 0777) < 0) {
 			if (strOSDirName)
 				rmdir(strOSDirName);
-			rmdir(strMainDirName);
+			if (strMainDirName)
+				rmdir(strMainDirName);
 			err = -1;
-	}
+		}
 	}
 
 exit_status: