implementation of session facade design pattern #1278 #3121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iluwatar
requested changes
Dec 14, 2024
session-facade/pom.xml
Outdated
Comment on lines
40
to
44
| <properties> | ||
| <maven.compiler.source>17</maven.compiler.source> | ||
| <maven.compiler.target>17</maven.compiler.target> | ||
| <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | ||
| </properties> |
There was a problem hiding this comment.
These come from the parent pom.xml
session-facade/pom.xml
Outdated
| <scope>test</scope> | ||
| </dependency> | ||
| </dependencies> | ||
|
|
There was a problem hiding this comment.
Add maven-assembly-plugin so that we can execute the code example from the command line. See other patterns for examples.
Comment on lines
28
to
30
| /** | ||
| * The type App. | ||
| */ |
There was a problem hiding this comment.
Explain the pattern here. Describe how the code example implements it.
Comment on lines
74
to
81
| for (Product product : productCatalog) { | ||
| if (productId == product.id()) { | ||
| this.cart.remove(product); | ||
| LOGGER.info("{} successfully removed from the cart", product); | ||
| return; | ||
| } | ||
| } | ||
| LOGGER.info("No product is found with the id {}", productId); |
There was a problem hiding this comment.
Instead of iterating list, could we use a more convenient data structure (e.g. map)?
|
|
Thank you very much for your valuable feedback, I have reviewed the comments and made the necessary changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
This pull request addresses issue #1278, I implemented the Session Facade design pattern to simplify the interface for interacting with complex ecommerce functionalities. The primary goal was to demonstrate how the Session Facade can act as an intermediary, providing a simplified interface to a series of interconnected, complex operations. For more info please refer to the readme file under the session-facade module.