Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build refactor #17

Merged
merged 4 commits into from
Sep 5, 2023
Merged

Build refactor #17

merged 4 commits into from
Sep 5, 2023

Conversation

danielle-casella-adams
Copy link
Member

Summary of PR changes

  • Refactor the template with the latest reusable template and contribution guidance

@danielle-casella-adams danielle-casella-adams requested a review from a team as a code owner August 31, 2023 22:36
hpractv
hpractv previously approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@hpractv hpractv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of grammar things, but you can decide if you want to change them in this or the other PRs.

.github/workflows/build-and-review-pr.yml Outdated Show resolved Hide resolved
.github/workflows/increment-version-on-merge.yml Outdated Show resolved Hide resolved
@danielle-casella-adams @hpractv
Apply suggestions from code review
55e1106 
Co-authored-by: Roy Wong <hpractv@users.noreply.github.com>
@danielle-casella-adams danielle-casella-adams merged commit 5457782 into main Sep 5, 2023
2 checks passed
@danielle-casella-adams danielle-casella-adams deleted the build-refactor branch September 5, 2023 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hpractv hpractv hpractv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielle-casella-adams @hpractv