ARCH-1690 - Adding a test job to the build-and-review-pr.yml #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielle-casella-adams
force-pushed
the
tests
branch
from
25bda8c
to
3ed6948
Compare
hpractv
reviewed
Oct 11, 2023
README.md
Outdated
| @@ -135,6 +137,10 @@ npm run build | |||
|
|
|||
| If changes are made to the action's [source code], the [usage examples] section of this file should be updated with the next version of the action. Each instance of this action should be updated. This helps users know what the latest tag is without having to navigate to the Tags page of the repository. See [Incrementing the Version] for details on how to determine what the next version will be or consult the first workflow run for the PR which will also calculate the next version. | |||
|
|
|||
| ### Tests | |||
|
|
|||
| The build and review PR workflow includes tests which are linked to a status check that needs to succeed before a PR is merged to the default branch. When a PR comes from a branch there should not be any issues running the tests. When a PR comes from a fork, tests may not have the required permissions or access to run since the `GITHUB_TOKEN` only has `read` access set for all scopes and fork's cannot access other secrets in the repository. In these scenarios, a fork may need to be merged into an intermediate branch by the repository owners to ensure the tests run successfully prior to a merge to the default branch. | |||
There was a problem hiding this comment.
Same thing as the wording for this spot in your other PR: im-open/composite-action-template#19 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of PR changes
Adding a test job to the build-and-review-pr.yml
PR Requirements
+semver:keywords.NOTE: If the repo's workflow could not automatically update the
README.md, it should be updated manually with the next version. For javascript actions, if the repo's workflow could not automatically recompile the action it should also be updated manually as part of the PR.