From a024e31f0abb85058f85ed20c4e1c3e1ee0caed4 Mon Sep 17 00:00:00 2001 From: Ayush Saini <36878972+imayushsaini@users.noreply.github.com> Date: Sun, 16 Jul 2023 03:08:55 +0530 Subject: [PATCH] fixed dynamic canonical --- src/app/pages/homepage/homepage.component.ts | 1 - src/app/services/seoservice.service.ts | 8 ++++---- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/src/app/pages/homepage/homepage.component.ts b/src/app/pages/homepage/homepage.component.ts index d9a7315..7843879 100644 --- a/src/app/pages/homepage/homepage.component.ts +++ b/src/app/pages/homepage/homepage.component.ts @@ -27,7 +27,6 @@ export class HomepageComponent implements OnInit,OnDestroy { this._seoService.updateOgUrl(data.ogUrl); //Updating Description tag dynamically with title this._seoService.updateDescription(data.description) - this._seoService.updateCanonicalTag("https://bombsquad-community.web.app/home") }); } diff --git a/src/app/services/seoservice.service.ts b/src/app/services/seoservice.service.ts index 91112a4..01ecb84 100644 --- a/src/app/services/seoservice.service.ts +++ b/src/app/services/seoservice.service.ts @@ -15,14 +15,14 @@ export class SEOServiceService { } updateOgUrl(url: string) { - this.meta.addTag({ name: 'og:url', content: url }) + this.meta.updateTag({ name: 'og:url', content: url }) + this.meta.removeTag('rel="canonical"'); + this.meta.addTag({ rel: 'canonical', href: url }); } updateDescription(desc: string) { this.meta.updateTag({ name: 'description', content: desc }) this.meta.updateTag({ name: 'og:description', content: desc }) } - updateCanonicalTag(url:string ) { - this.meta.addTag({ rel: 'canonical', href: url }); - } + }