improvements

Issue #157
imixs · Oct 3, 2024 · 8d3efa3 · 8d3efa3
1 parent 59a3fd3
commit 8d3efa3
Show file tree

Hide file tree

Showing 3 changed files with 33 additions and 4 deletions.
diff --git a/...p-server/src/main/java/org/openbpmn/extensions/elements/LinkEventDefinitionExtension.java b/...p-server/src/main/java/org/openbpmn/extensions/elements/LinkEventDefinitionExtension.java
@@ -130,15 +130,20 @@ public void buildPropertiesForm(final BPMNElement bpmnElement, final DataBuilder
     public boolean updatePropertiesData(final JsonObject json, final String category, final BPMNElement bpmnElement,
             final GModelElement gNodeElement) {
 
+        boolean updateClient = false;
         // we are only interested in category link
         if ("Link".equals(category)) {
             Event bpmnEvent = (Event) bpmnElement;
+            Set<Element> oldDefinitionList = bpmnEvent.getEventDefinitionsByType("linkEventDefinition");
+
             JsonArray dataList = json.getJsonArray("links");
 
             // synchronize the definition list of the event element
             Set<Element> linkEventDefinitions = synchronizeEventDefinitions("linkEventDefinition", bpmnEvent,
                     dataList);
-
+            if (oldDefinitionList.size() != linkEventDefinitions.size()) {
+                updateClient = true;
+            }
             // just update the values one by one by referring to the signalRef id by
             // comparing the name
             Iterator<Element> iter = linkEventDefinitions.iterator();
@@ -155,7 +160,11 @@ public boolean updatePropertiesData(final JsonObject json, final String category
             }
         }
 
-        return false;
+        if (updateClient) {
+            // modelState.reset();
+            modelState.refreshGModelState();
+        }
+        return updateClient;
 
     }
 }
diff --git a/...server/src/main/java/org/openbpmn/extensions/elements/SignalEventDefinitionExtension.java b/...server/src/main/java/org/openbpmn/extensions/elements/SignalEventDefinitionExtension.java
@@ -164,14 +164,20 @@ public void buildPropertiesForm(final BPMNElement bpmnElement, final DataBuilder
     public boolean updatePropertiesData(final JsonObject json, final String category, final BPMNElement bpmnElement,
             final GModelElement gNodeElement) {
 
+        boolean updateClient = false;
         // we are only interested in category signals
         if ("Signals".equals(category)) {
 
             Event bpmnEvent = (Event) bpmnElement;
+            Set<Element> oldDefinitionList = bpmnEvent.getEventDefinitionsByType("signalEventDefinition");
+
             JsonArray dataList = json.getJsonArray("signals");
             // synchronize the definition list of the event element
             Set<Element> signalEventDefinitions = synchronizeEventDefinitions("signalEventDefinition", bpmnEvent,
                     dataList);
+            if (oldDefinitionList.size() != signalEventDefinitions.size()) {
+                updateClient = true;
+            }
             // now we can update the values
             Iterator<Element> iter = signalEventDefinitions.iterator();
             int i = 0;
@@ -185,7 +191,11 @@ public boolean updatePropertiesData(final JsonObject json, final String category
                 // update completed
             }
         }
-        return false;
+        if (updateClient) {
+            // modelState.reset();
+            modelState.refreshGModelState();
+        }
+        return updateClient;
 
     }
 }
diff --git a/...-server/src/main/java/org/openbpmn/extensions/elements/TimerEventDefinitionExtension.java b/...-server/src/main/java/org/openbpmn/extensions/elements/TimerEventDefinitionExtension.java
@@ -188,15 +188,21 @@ public void buildPropertiesForm(final BPMNElement bpmnElement, final DataBuilder
     public boolean updatePropertiesData(final JsonObject json, final String category, final BPMNElement bpmnElement,
             final GModelElement gNodeElement) {
 
+        boolean updateClient = false;
         // we are only interested in category 'Timer Definitions'
         if ("Timer Definitions".equals(category)) {
 
             Event bpmnEvent = (Event) bpmnElement;
+            Set<Element> oldDefinitionList = bpmnEvent.getEventDefinitionsByType("timerEventDefinition");
+
             JsonArray dataList = json.getJsonArray("timers");
 
             // synchronize the definition list of the event element
             Set<Element> timerEventDefinitions = synchronizeEventDefinitions("timerEventDefinition", bpmnEvent,
                     dataList);
+            if (oldDefinitionList.size() != timerEventDefinitions.size()) {
+                updateClient = true;
+            }
 
             // now we can update the values one by one
             // NOTE: the id can change within the definitionList if an element was deleted
@@ -239,6 +245,10 @@ public boolean updatePropertiesData(final JsonObject json, final String category
                 // update completed
             }
         }
-        return false;
+        if (updateClient) {
+            // modelState.reset();
+            modelState.refreshGModelState();
+        }
+        return updateClient;
     }
 }