Allow generic-hand #121
Merged
Allow generic-hand #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ada mentioned on the issue:
As such, this feels appropriate. LGTM |
github-actions bot
added a commit
that referenced
this pull request
Feb 7, 2024
SHA: 16b0371 Reason: push, by Manishearth Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
Ah, sorry! Will do when back at computer. |
yes, your change is not compatible with what we are currently doing. |
|
Reverted: #122 |
|
#123 is the new PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's unclear to me if we shoudl require "generic-hand" at all times or allow "generic-hand-select" input methods to omit "generic-hand" (thoughts @cabanier?)
Fixes immersive-web/webxr#1358
Preview | Diff