Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for ES256 signature algorithm #236

Merged
merged 37 commits into from
Aug 6, 2024
Merged

Conversation

nanderstabel
Copy link
Contributor

@nanderstabel nanderstabel commented May 21, 2024

Description of change

Although did_manager is capabable of creating and storing a ES256K key, we cannot enable it since the library we use for signing (jsonwebtoken) we use in oid4vc only supports ES256 and not ES256K.

Links to any relevant issues

How the change has been tested

Manually tested against impierce/ssi-agent#101

In that UniCore is a description of how UniMe can be tested against UniCore.

Definition of Done checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@nanderstabel nanderstabel self-assigned this May 21, 2024
@nanderstabel nanderstabel added the Added A new feature that requires a minor release. label May 21, 2024
@nanderstabel nanderstabel linked an issue May 21, 2024 that may be closed by this pull request
1 task
@nanderstabel nanderstabel marked this pull request as ready for review May 22, 2024 14:41
@daniel-mader daniel-mader removed the Blocked An issue that is blocked by another issue or another blocker. label Jul 16, 2024
@daniel-mader daniel-mader marked this pull request as ready for review July 16, 2024 15:22
Copy link
Member

@maiertech maiertech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine in principle, but let me have a look again after rebasing.

Copy link
Member

@maiertech maiertech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine in principle, but let me have a look again after rebasing.

@nanderstabel
Copy link
Contributor Author

I've rebased this branch (and also fixed a bug where the preferred signing algorithm was not being respected), so it is now finally ready for the final review.

@nanderstabel nanderstabel marked this pull request as ready for review July 31, 2024 14:31
@daniel-mader daniel-mader changed the title feat: add support for ES256 feat: add support for ES256 signature algorithm Aug 5, 2024
@nanderstabel nanderstabel merged commit da5f06f into dev Aug 6, 2024
3 checks passed
@nanderstabel nanderstabel deleted the feat/es256 branch August 6, 2024 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Added A new feature that requires a minor release.
Projects
Development

Successfully merging this pull request may close these issues.

Support DIIP V2.1 specifications
4 participants