-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for ES256
signature algorithm
#236
Conversation
identity-wallet/src/state/credentials/reducers/handle_oid4vp_authorization_request.rs
Outdated
Show resolved
Hide resolved
identity-wallet/src/state/credentials/reducers/handle_oid4vp_authorization_request.rs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine in principle, but let me have a look again after rebasing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fine in principle, but let me have a look again after rebasing.
I've rebased this branch (and also fixed a bug where the preferred signing algorithm was not being respected), so it is now finally ready for the final review. |
ES256
ES256
signature algorithm
Description of change
Although
did_manager
is capabable of creating and storing aES256K
key, we cannot enable it since the library we use for signing (jsonwebtoken
) we use inoid4vc
only supportsES256
and notES256K
.Links to any relevant issues
How the change has been tested
Manually tested against impierce/ssi-agent#101
In that UniCore is a description of how UniMe can be tested against UniCore.
Definition of Done checklist
Add an
x
to the boxes that are relevant to your changes.