feat: builder pattern for id_token and response #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanderstabel
changed the title
Add tests for RequestUrl Add missing request parameters Add sphereon demo website test Update documentation with new RequestUrl Remove sphereon demo example Add validate_request method to Provider struct Add preoper Ser and De for SiopRequest and RequestBuilder Add skeptic for Markdown code testing Add support for Request by reference fix: fix rebase conflicts Add comments and fix some tests fix: Move `derivative` to dev-dependencies Refactor Provider and Subject improve tests and example using wiremock Improve struct field serde fix: remove claims from lib.rs style: fix arguments order Add did:key DID method Add support for Request by reference fix: Remove lifetime annotations Add preoper Ser and De for SiopRequest and RequestBuilder Add Scope and Claim fix: fix rebase conflicts
nanderstabel
force-pushed
the
feat/builders
branch
from
c3f4839
to
79053a2
Compare
6 tasks
daniel-mader
previously approved these changes
Jun 7, 2023
src/lib.rs
Outdated
|
|
||
| #[macro_export] | ||
| macro_rules! builder_fn { | ||
| ( $name:ident, $ty:ty) => { |
There was a problem hiding this comment.
Is this whitespace before $name intended? If no, why did fmt not find it?
There was a problem hiding this comment.
Oh no not intended, nice catch. Apparently cargo fmt has more difficulties with formatting macros so good to take that into consideration 👍 : rust-lang/rustfmt#8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Moved (and improved)
builder_fn!andparse_othertolib.rssince they can be reused for multiple builders and structs.Links to any relevant issues
#20
How the change has been tested
Multiple unit tests
Definition of Done checklist
Add an
xto the boxes that are relevant to your changes.