-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for using multiple DID methods #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nanderstabel
force-pushed
the
feat/multi-did-methods
branch
2 times, most recently
from
April 4, 2024 20:38
6babdd9
to
cc192b4
Compare
nanderstabel
force-pushed
the
feat/multi-did-methods
branch
2 times, most recently
from
April 11, 2024 15:32
13f24f5
to
676793f
Compare
nanderstabel
changed the title
Feat/multi did methods
feat: add support for using multiple DID methods
Apr 11, 2024
nanderstabel
added
Added
A new feature that requires a minor release.
Breaking change
A change to the API that requires a major release.
and removed
Added
A new feature that requires a minor release.
labels
Apr 11, 2024
nanderstabel
force-pushed
the
feat/multi-did-methods
branch
from
April 11, 2024 15:42
676793f
to
986af6e
Compare
This was referenced Apr 19, 2024
daniel-mader
approved these changes
Apr 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding support for a new feature while having a negative total amount of lines changed ... I like that! 😉
Oran-Dan
reviewed
Apr 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This change adds the functionality of using multiple different DID methods through one single
Subject
.Links to any relevant issues
impierce/identity-wallet#94
How the change has been tested
Added the new
MultiDidMethodSubject
struct totests/siopv2/implicit.rs
and added#[rstest::rstest]
totest_implicit_flow
. This waytest_implicit_flow
is tested twice, once fordid:key
and once fordid:test
.Definition of Done checklist
Add an
x
to the boxes that are relevant to your changes.