Deprecate Presentation Definition by Reference

[nanderstabel]

Description

Remove the option to supply a presentation_definition_id to the /v0/authorization_requests endpoint.

Motivation

The current implementation is quite questionable since it's relying on a bunch of unconventional workarounds like:

  # docker-compose.yml
  volumes:
      # TODO: Remove this. This is a workaround that ensures that the `agent_verification/presentation_definitions`
      # folder can be accessed by the agent from the `fn authorization_requests` endpoint.
      - ./tmp:/app/agent_api_rest

and

    // `agent_api_rest/src/verification/authorization_requests.rs` 
            // TODO: This needs to be properly fixed instead of reading the presentation definitions from the file system
            // everytime a request is made. `PresentationDefinition`'s should be implemented as a proper `Aggregate`. This
            // current suboptimal solution requires the `./tmp:/app/agent_api_rest` volume to be mounted in the `docker-compose.yml`.
            PresentationDefinitionResource::PresentationDefinitionId(presentation_definition_id) => {
                let project_root_dir = env!("CARGO_MANIFEST_DIR");

                serde_json::from_reader(
                    std::fs::File::open(format!(
                        "{project_root_dir}/../agent_verification/presentation_definitions/{presentation_definition_id}.json"
                    ))
                    .unwrap(),
                )
                .unwrap()
            }

Also, Presentation Definition by Value has already been implemented in #72.

In the future we might want to support Presentation Definition by Reference again, but then it must be implemented in a proper way.

Resources

• feat: add support for PresentationDefinition by value #72

To-do List

• Deprecate Presentation Definition by Reference