Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change url to uri #104

Merged
merged 2 commits into from
Aug 7, 2024
Merged

fix: change url to uri #104

merged 2 commits into from
Aug 7, 2024

Conversation

nanderstabel
Copy link
Collaborator

Description of change

As title

Links to any relevant issues

How the change has been tested

  • Tested using the Postman Collection (checking the response from the oid4vci/openid-credential-issuer Request
  • Tested manually with UniMe

Definition of Done checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have successfully tested this change in a docker environment

@nanderstabel nanderstabel self-assigned this Aug 7, 2024
@nanderstabel nanderstabel added the Bug Something isn't working label Aug 7, 2024
@nanderstabel nanderstabel marked this pull request as ready for review August 7, 2024 14:15
@nanderstabel nanderstabel merged commit 47f4f82 into dev Aug 7, 2024
1 check passed
@nanderstabel nanderstabel deleted the fix/url-to-uri branch August 7, 2024 21:45
berkes pushed a commit to educredentials/ssi-agent that referenced this pull request Aug 14, 2024
* fix: change `url` to `uri`

* chore: update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants