Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: application configuration #107

Merged
merged 11 commits into from
Aug 8, 2024
Merged

docs: application configuration #107

merged 11 commits into from
Aug 8, 2024

Conversation

daniel-mader
Copy link
Contributor

Description of change

Updates the docs to match the changes made in #94.

Links to any relevant issues

How the change has been tested

n/a

Definition of Done checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have successfully tested this change in a docker environment

@daniel-mader daniel-mader added the Documentation Improvements or additions to documentation label Aug 7, 2024
@daniel-mader daniel-mader self-assigned this Aug 7, 2024
@daniel-mader daniel-mader changed the title docs: configuration docs: application configuration Aug 7, 2024
Copy link
Collaborator

@nanderstabel nanderstabel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice overview!

Maybe for a future improvement we should also somehow document which configurations are REQUIRED, OPTIONAL, and/or CONDITIONAL

agent_application/CONFIGURATION.md Outdated Show resolved Hide resolved
agent_application/CONFIGURATION.md Outdated Show resolved Hide resolved
Base automatically changed from refactor/docker to dev August 8, 2024 14:55
@daniel-mader daniel-mader merged commit 430797b into dev Aug 8, 2024
1 check passed
@daniel-mader daniel-mader deleted the docs/config branch August 8, 2024 15:13
berkes pushed a commit to educredentials/ssi-agent that referenced this pull request Aug 14, 2024
* fix: docker compose file

* fix: broken `Host` in `pgadmin` server config

* refactor: rename Docker Compose file according to latest guides

* docs: update & shorten

* chore: remove obsolete `version`

* chore: add example file

* WIP

* docs: bump to match latest version

* refactor: rename headings

* docs: apply feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants